Skip to content

Rename package #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2020
Merged

Rename package #15

merged 3 commits into from
Jul 8, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jul 8, 2020

pint-pandas recently renamed its main package from pintpandas to pint_pandas. I think we should also rename since this is easier to read.

Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had originally thought that using underscores in modules names was discouraged by PEP-8, but it seems if your module has to have a two-word name then an underscore is okay.

@keewis
Copy link
Collaborator Author

keewis commented Jul 8, 2020

you're right, PEP-8 does say that this is discouraged. However, there is already a significant amount of widely-used packages that simply ignore this rule, e.g. setuptools_scm, prompt_toolkit or more_itertools. I guess that guideline / convention changed a bit since the time the PEP was written (initial post was 2001, last update seems to have been 2013)?

@keewis keewis merged commit 7e8e0d2 into xarray-contrib:master Jul 8, 2020
@keewis keewis deleted the rename-package branch July 8, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants