-
Notifications
You must be signed in to change notification settings - Fork 13
upstream-dev CI #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream-dev CI #19
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 7 7
Lines 614 614
=======================================
Hits 506 506
Misses 108 108 Continue to review full report at Codecov.
|
the CI seems to work, so this should be ready for review and merge. I'd especially take a look at the upstream-dev dependencies: should we add more, like the main indirect dependencies of xarray (pandas, mostly). |
Do we want to have this CI job be optional or not (i.e., should an upstream but unreleased break hold up PRs here until it is fixed)? Though, that may require it to be a separate check (which I'm not sure on what the status of separate checks is from #16). |
we didn't activate the branch protection, so I'd say if the fix wouldn't take too long it's fine to merge with a failing upstream-dev CI. If it's not clear how to fix that (even upstream) we could just add conditional xfails. The separate checks don't work yet (not even when copying |
@keewis Sounds good. Hopefully the separate checks can get figured out at some point. I think then that this should be good to merge. |
This adds a upstream-dev CI.