xdp-dump: add check for new promiscuous mode message in tests #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it fixes the failure mentioned in 415. |
tohojo
requested changes
Jun 19, 2024
xdp-dump/tests/test-xdpdump.sh
Outdated
| @@ -448,11 +448,11 @@ test_promiscuous_selfload() | |||
| fi | |||
|
|
|||
| RESULT=$(dmesg) | |||
| if [[ "$RESULT" != *"device $NS entered promiscuous mode"* ]]; then | |||
| if [[ "$RESULT" != *"device $NS entered promiscuous mode"* && "$RESULT" != *"$NS: entered promiscuous mode"* ]]; then | |||
There was a problem hiding this comment.
Better to combine these as two distinct 'test' invocations, like:
if [[ "$RESULT" != *"device $NS entered promiscuous mode"* ]] && [[ "$RESULT" != *"$NS: entered promiscuous mode"* ]]; then
same for all of the checks below, obviously :)
There was a problem hiding this comment.
Thanks, @tohojo I updated and tested the patch as your suggestion.
kernel updated the promiscuous mode message in below commit, so update the previous check condition. net/core: refactor promiscuous mode message old message: [ 406.034418] device eth0 entered promiscuous mode [ 408.424703] device eth0 left promiscuous mode new message: [ 406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode [ 408.424715] ice 0000:17:00.0 eth0: left promiscuous mode Signed-off-by: Xiao Liang <[email protected]>
tohojo
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kernel updated the promiscuous mode message in below commit, so update the previous check condition.
net/core: refactor promiscuous mode message
old message:
[ 406.034418] device eth0 entered promiscuous mode
[ 408.424703] device eth0 left promiscuous mode
new message:
[ 406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode
[ 408.424715] ice 0000:17:00.0 eth0: left promiscuous mode