Increase MAX_CPUS to 512 #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohojo
requested changes
Mar 3, 2025
Previously, MAX_CPUS was set to 256. This causes the tool to exit with a failure on systems with more than 256 CPUs. For example, an AMD EPYC server with two AMD EPYC 9684X 96-Core Processors reports 384 CPUs to the kernel due to hyperthreading. This fix allows such systems to run the xdpdump utility. Signed-off-by: Lucas Crijns <[email protected]>
|
I added the requested changes and updated the commit message. |
tohojo
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Looks good, thanks!
I don't think we should increase it further as this adds overhead for all systems (being a compile-time value). If we need to scale to a higher number of CPUs we should start sizing things dynamically at runtime (or maybe find some way to avoid the per-CPU stuff if possible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase MAX_CPUS from 256 to 512 to support higher cpu count systems.
Fixes #485