Skip to content

refactor!: sonner v2 changes#115

Merged
xiaoluoboding merged 13 commits intoxiaoluoboding:mainfrom
sadeghbarati:sonner-v2
May 21, 2025
Merged

refactor!: sonner v2 changes#115
xiaoluoboding merged 13 commits intoxiaoluoboding:mainfrom
sadeghbarati:sonner-v2

Conversation

@sadeghbarati
Copy link
Copy Markdown
Contributor

@sadeghbarati sadeghbarati commented May 16, 2025

Close #112
Close #108 (CSS file now is separate file)
Close #106
Close #89
Close #62

  • Used tsdown for bundling the pkg, use Vite only for dev mode
  • Add new export field for CSS file, removed inline CSS in head tag (__insertCSSVueSonner)
  • Update nuxt-module-build and remove cjs exports

Distribution Strategy Nuxt Transpile Required included in this PR
tsdown No Yes
mkdist No No (but we can add mkdist too)
export source files Yes Yes
mkdist details

{
 ...
  "scripts": {
    "build:sfc": "mkdist --src=./src/packages/ --dist=./lib/sfc -d",
  },
  "exports": {
    ...
    "./sfc": {
      "types": "./lib/index.d.ts",
      "import": "./lib/index.mjs"
    },
    ...
    }
  },
  ...
}

image

Please feel free to make any changes to the code if you’d like 🙏.

GL, best regards

@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 9:19am

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 16, 2025

Open in StackBlitz

npm i https://pkg.pr.new/xiaoluoboding/vue-sonner@115

commit: 35490b3

…move some anti-pattern codes

Copilot suggestions
@xiaoluoboding xiaoluoboding merged commit 1a5e133 into xiaoluoboding:main May 21, 2025
5 checks passed
@sadeghbarati sadeghbarati deleted the sonner-v2 branch May 21, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants