Skip to content

Add playwright test from Sonner package and fix dismiss function#91

Merged
xiaoluoboding merged 7 commits intoxiaoluoboding:mainfrom
CMarzin:add-playwright-test
Oct 20, 2024
Merged

Add playwright test from Sonner package and fix dismiss function#91
xiaoluoboding merged 7 commits intoxiaoluoboding:mainfrom
CMarzin:add-playwright-test

Conversation

@CMarzin
Copy link
Copy Markdown
Contributor

@CMarzin CMarzin commented Oct 17, 2024

Hello @xiaoluoboding can you check this pull request to see if this is ok for you ?

This pull requests adds :

  • The tests from the React Sonner package.
  • It fix the dismiss function
  • It add documentation on how to run the test

All the test pass except for this one "return focus to the previous focused element"

I can't see why the deploy why the deploy failed on Vercel can you share the log maybe so I can fix this error ?

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 2:43am

@CMarzin CMarzin changed the title Add playwright test from Sonner package Add playwright test from Sonner package and fix dismiss function Oct 18, 2024
@CMarzin CMarzin marked this pull request as ready for review October 18, 2024 14:23
@xiaoluoboding
Copy link
Copy Markdown
Owner

xiaoluoboding commented Oct 18, 2024

Hello @xiaoluoboding can you check this pull request to see if this is ok for you ?

This pull requests adds :

  • The tests from the React Sonner package.
  • It fix the dismiss function
  • It add documentation on how to run the test

All the test pass except for this one "return focus to the previous focused element"

I can't see why the deploy why the deploy failed on Vercel can you share the log maybe so I can fix this error ?

@CMarzin I will check it later, it seems development has some issues.

@CMarzin OK, you can remove the pnpm-lock.yaml and reinstall the package, it will renew the pnpm-lock.yaml

Maybe it will pass the development.

CleanShot 2024-10-19 at 00 02 20@2x

@CMarzin
Copy link
Copy Markdown
Contributor Author

CMarzin commented Oct 18, 2024

Thanks i have now fixed the lock file, I used an old version of pnpm.

@xiaoluoboding
Copy link
Copy Markdown
Owner

@CMarzin Thank you for the excellent work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants