-
Notifications
You must be signed in to change notification settings - Fork 942
Fixed Issue when USE_WEIGHTS_FILE
Flag Enabled
#263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…without blob data file
…h blob data file weights_blob.bin
About the first three patches, building should be handled by the build system, but hardcoded shell sccripts. About the last one, I'm not sure what it's meant to fix. You cannot just just copy that code to a different file since it's actually auto-generated. As for the readability patch, I see there's a missing "b" for writing on Windows, but beyond that it's mostly just re-indenting the code, which is pointless. |
@jmvalin |
The weights in rnnoise_data.c are all inside a |
Yes but the source code is too heavy. |
Summary
Fixed some issues when
USE_WEIGHTS_FILE
Flag is enabled.Description
USE_WEIGHTS_FILE
Flag is enabled,rnnoise_data.c
which has huge huge lines is not used for compile program. Butinit_rnnoise
Function is included inrnnoise_data.c
so compile must be needed.init_rnnoise
Function intodenoise.c
.weight_blob.bin
withwrite_weights.c
, it generated.bin
file withw
mode, but we are generating justb
file so I editedw
aswb
of file function parameter.write_weights.c
has same work as old one, but I improved code readability and debugability..sh
scripts are compile helper for debuggers.