Skip to content

Added additional include path to search within, supporting Mac OS brew u... #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2014

Conversation

tache
Copy link
Contributor

@tache tache commented Jul 11, 2014

This change resolves the issue where the include files for icu4c are not being found. They reside in the brew installed directory of /usr/local/include/unicode. The build was only searching in the /opt/local/include hierarchy common to MacPorts.

See these issues...
#47
#25

error experienced

> [email protected] install ./node_modules/node-stringprep
> node-gyp rebuild

  CXX(target) Release/obj.target/node_stringprep/node-stringprep.o
../node-stringprep.cc:2:10: fatal error: 'unicode/unistr.h' file not found
#include <unicode/unistr.h>
         ^
1 error generated.

@tache
Copy link
Contributor Author

tache commented Jul 11, 2014

I should add that I ran into this when node-xmpp build failed. That module contains the node-xmpp-core dependency, which that build will still fail after this patch since the dependency in that module is

 'node-stringprep': '^0.4.0',

@lloydwatkin
Copy link
Contributor

Thanks for your PR, am publishng now.

lloydwatkin added a commit that referenced this pull request Jul 11, 2014
Added additional include path to search within, supporting Mac OS brew u...
@lloydwatkin lloydwatkin merged commit 0f70027 into xmppo:master Jul 11, 2014
@lloydwatkin
Copy link
Contributor

Pushed as 0.5.2

@lloydwatkin
Copy link
Contributor

Also pushed [email protected] for this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants