node 4x retry #74
node 4x retry #74
Conversation
|
@sonnyp Maybe you can take a peek at this one? Should be a lot closer. I think all the Nan2 stuff is working - but the core tests are failing :/ |
|
Hey @sonnyp Well, I'm close. Very close. Can't figure how why it's not throwing exceptions for fallback JS profiles properly... I've got to stop working on this now (ran out of time). HUUUGE thanks goes out to anyone who spends some time on this for me :) Thanks! |
| @@ -7,7 +7,7 @@ var UIDNA_ALLOW_UNASSIGNED = 1 | |||
| var UIDNA_USE_STD3_RULES = 2 | |||
|
|
|||
| try { | |||
| var bindings = require('bindings')('node_stringprep.node') | |||
| var bindings = require('./node_modules/bindings/bindings.js')('node_stringprep.node') | |||
There was a problem hiding this comment.
whoa, no, why was this changed?
|
You should be able to replace all references to |
|
|
|
https://github.com/nodejs/nan/blob/master/doc/scopes.md#nanescapablehandlescope - you also need to use |
| NanThrowError(errorName()); | ||
| return NanUndefined(); | ||
| Nan::ThrowError(u_errorName(error)); | ||
| return Nan::Undefined(); |
There was a problem hiding this comment.
this is the scope.Escape(Nan::Undefined())
|
I did a write-up @ https://nodesource.com/blog/cpp-addons-for-nodejs-v4 about the upgrade process that's a bit more verbose than other resources currently available |
Trying via https://gist.github.com/thlorenz/7e9d8ad15566c99fd116