Update to use zarr python >= 3.0 #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiannucci
changed the title
abkfenris
force-pushed
the
zarr3compat
branch
from
d6c262b to
3fd3cc3
Compare
|
The only thing left is the annoying metadata test which has issues with the fill values not matching up for some reason |
|
This is the last blocker i believe: zarr-developers/zarr-python#2990 |
|
Once zarr-developers/zarr-python#2996 is released this can pin the zarr version minimum and be merged to main |
mpiannucci
changed the title
|
@abkfenris Once this is merged i would like to tag a release |
|
@mpiannucci go for it |
jhamman
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Thanks @mpiannucci for working on this. I have to say that I'm pleasantly surprised by how small the diff is here. Onward!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zarr plugin will still be zarr 2 format for now, but we are moving on with the core zarr support
Closes #290