Skip to content

format color value to style '#rrggbbaa'#2629

Merged
Tyriar merged 2 commits intoxtermjs:masterfrom
ivanwonder:convert-color
Dec 26, 2019
Merged

format color value to style '#rrggbbaa'#2629
Tyriar merged 2 commits intoxtermjs:masterfrom
ivanwonder:convert-color

Conversation

@ivanwonder
Copy link
Copy Markdown
Contributor

@ivanwonder ivanwonder commented Dec 13, 2019

Now the color config doesn't support the all color format.
Use the method described here.
#2560 (comment)

Fixes #2620

@Tyriar Tyriar added this to the 4.4.0 milestone Dec 26, 2019
Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well 👍

@Tyriar Tyriar merged commit 5a17825 into xtermjs:master Dec 26, 2019
Tyriar added a commit to microsoft/vscode that referenced this pull request Dec 31, 2019
xterm-addon-webgl@0.5.0-beta.7

Diff: xtermjs/xterm.js@8341c35...2a9e16b

- Include  in word separators xtermjs/xterm.js#2583
- Remove unused imports/functions xtermjs/xterm.js#2585
- force alpha to 1 when using background color as inverted foreground color xtermjs/xterm.js#2560
- Fix minimumContrastRatio on dom/truecolor xtermjs/xterm.js#2602
- v4.3.0 xtermjs/xterm.js#2605
- Avoid roundtrip to browser when double-disposing. xtermjs/xterm.js#2616
- Allow the thickness of the bar cursor to be configured xtermjs/xterm.js#2590
- update version of node-pty xtermjs/xterm.js#2621
- Implement hidden in DOM and WebGL renderers xtermjs/xterm.js#2625
- Expose texture atlas as API and use in demo xtermjs/xterm.js#2626
- Webgl v0.4.1 xtermjs/xterm.js#2628
- Add Linode to real world uses xtermjs/xterm.js#2636
- Added Gus to list of xterm real-world users xtermjs/xterm.js#2631
- Remove a large portion of InputHandler's dependency on Terminal xtermjs/xterm.js#2637
- Move back to reseting parser only on RIS xtermjs/xterm.js#2640
- Set glyph fg color based on original bg, not selection xtermjs/xterm.js#2650
- format color value to style '#rrggbbaa' xtermjs/xterm.js#2629
- Use register over add for APIs returning disposables xtermjs/xterm.js#2651
- Standardize how colors helper lib is structured xtermjs/xterm.js#2653
- Fullwidth handling in buffer writes xtermjs/xterm.js#2644
- Target es5 in attach addon xtermjs/xterm.js#2654

Fixes #86194
Fixes #87918
Part of #87456
lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
xterm-addon-webgl@0.5.0-beta.7

Diff: xtermjs/xterm.js@8341c35...2a9e16b

- Include  in word separators xtermjs/xterm.js#2583
- Remove unused imports/functions xtermjs/xterm.js#2585
- force alpha to 1 when using background color as inverted foreground color xtermjs/xterm.js#2560
- Fix minimumContrastRatio on dom/truecolor xtermjs/xterm.js#2602
- v4.3.0 xtermjs/xterm.js#2605
- Avoid roundtrip to browser when double-disposing. xtermjs/xterm.js#2616
- Allow the thickness of the bar cursor to be configured xtermjs/xterm.js#2590
- update version of node-pty xtermjs/xterm.js#2621
- Implement hidden in DOM and WebGL renderers xtermjs/xterm.js#2625
- Expose texture atlas as API and use in demo xtermjs/xterm.js#2626
- Webgl v0.4.1 xtermjs/xterm.js#2628
- Add Linode to real world uses xtermjs/xterm.js#2636
- Added Gus to list of xterm real-world users xtermjs/xterm.js#2631
- Remove a large portion of InputHandler's dependency on Terminal xtermjs/xterm.js#2637
- Move back to reseting parser only on RIS xtermjs/xterm.js#2640
- Set glyph fg color based on original bg, not selection xtermjs/xterm.js#2650
- format color value to style '#rrggbbaa' xtermjs/xterm.js#2629
- Use register over add for APIs returning disposables xtermjs/xterm.js#2651
- Standardize how colors helper lib is structured xtermjs/xterm.js#2653
- Fullwidth handling in buffer writes xtermjs/xterm.js#2644
- Target es5 in attach addon xtermjs/xterm.js#2654

Fixes microsoft#86194
Fixes microsoft#87918
Part of microsoft#87456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canvas selection doesn't accept rgba values in >=4.3

2 participants