Skip to content

vtfeatures v2#2754

Merged
jerch merged 1 commit intoxtermjs:masterfrom
jerch:fix_vtfeatures_2
Mar 10, 2020
Merged

vtfeatures v2#2754
jerch merged 1 commit intoxtermjs:masterfrom
jerch:fix_vtfeatures_2

Conversation

@jerch
Copy link
Copy Markdown
Member

@jerch jerch commented Mar 10, 2020

Jekyll is really picky and does not like the leading empty line before the YAML block.

@Tyriar: Not being able to devel and test this locally before adding to the repo is really annoying. Even worse here, since it spans two repos.

@jerch jerch added type/bug Something is misbehaving type/documentation Regarding website, API documentation, README, etc. labels Mar 10, 2020
@jerch jerch merged commit eaadb75 into xtermjs:master Mar 10, 2020
@Tyriar
Copy link
Copy Markdown
Member

Tyriar commented Mar 11, 2020

Not being able to devel and test this locally before adding to the repo is really annoying. Even worse here, since it spans two repos.

Would it be better to move this to xtermjs.org so it's a similar model to https://github.com/xtermjs/xtermjs.org/blob/master/bin/update-docs? The problem then is you could make a change in xterm.js@master that causes a breakage when we run this during release?

Ideally we'd have a pipeline to handle this and all updates to the website on release for us. Something you we could as a quick fix would be to move this over to xtermjs.org and set up a new pipeline job that clones it and verifies it runs against master without erroring out?

@jerch
Copy link
Copy Markdown
Member Author

jerch commented Mar 11, 2020

Tracked in #2755.

Tyriar added a commit to microsoft/vscode that referenced this pull request Apr 9, 2020
xtermjs/xterm.js@c5593bd...21b490f

Link provider fix
- Merge pull request xtermjs/xterm.js#2710 from jmbockhorst/linkFix

Leaked reference
- Merge pull request xtermjs/xterm.js#2767 from JavaCS3/fix/addDisposableDomListener-leak

Missing cursor fix
- Merge pull request xtermjs/xterm.js#2731 from jerch/fix_2729

Accessibility fix
- Merge pull request xtermjs/xterm.js#2814 from Tyriar/role_list

Fixes #93480

Showcase

Merge pull request xtermjs/xterm.js#2761 from slel/patch-1
Merge pull request xtermjs/xterm.js#2723 from UziTech/patch-1

Test, doc, build improvements

Merge pull request xtermjs/xterm.js#2766 from Tyriar/readme
Merge pull request xtermjs/xterm.js#2786 from Tyriar/eslint
Merge pull request xtermjs/xterm.js#2799 from Tyriar/enum_like_upper_case
Merge pull request xtermjs/xterm.js#2730 from Tyriar/ts38
Merge pull request xtermjs/xterm.js#2753 from jerch/fix_vtfeatures_template
Merge pull request xtermjs/xterm.js#2754 from jerch/fix_vtfeatures_2
Merge pull request xtermjs/xterm.js#2722 from Tyriar/linux_tests
Merge pull request xtermjs/xterm.js#2712 from jmbockhorst/playwright
Merge pull request xtermjs/xterm.js#2800 from Tyriar/upgrade_mac

Many dependency updates

Merge pull request xtermjs/xterm.js#2758 from Tyriar/acorn
Merge pull request xtermjs/xterm.js#2770 from xtermjs/dependabot/npm_and_yarn/deep-eq…
Merge pull request xtermjs/xterm.js#2779 from xtermjs/dependabot/npm_and_yarn/webpack…
Merge pull request xtermjs/xterm.js#2760 from xtermjs/dependabot/npm_and_yarn/acorn-5…
Merge pull request xtermjs/xterm.js#2772 from xtermjs/dependabot/npm_and_yarn/https-p…
Merge pull request xtermjs/xterm.js#2783 from Tyriar/deps
Merge pull request xtermjs/xterm.js#2795 from xtermjs/dependabot/npm_and_yarn/types/w…
Merge pull request xtermjs/xterm.js#2801 from xtermjs/dependabot/npm_and_yarn/types/w…
Merge pull request xtermjs/xterm.js#2780 from xtermjs/dependabot/npm_and_yarn/types/w…
Merge pull request xtermjs/xterm.js#2792 from xtermjs/dependabot/npm_and_yarn/mocha-7…
Merge pull request xtermjs/xterm.js#2803 from Tyriar/more_deps
Merge pull request xtermjs/xterm.js#2805 from xtermjs/dependabot/npm_and_yarn/mustach…
Merge pull request xtermjs/xterm.js#2810 from xtermjs/dependabot/npm_and_yarn/deep-eq…
Merge pull request xtermjs/xterm.js#2815 from xtermjs/dependabot/npm_and_yarn/nyc-15.0.1
Merge pull request xtermjs/xterm.js#2820 from xtermjs/dependabot/npm_and_yarn/typescr…
Merge pull request xtermjs/xterm.js#2819 from xtermjs/dependabot/npm_and_yarn/typescr…
@Tyriar Tyriar added this to the 4.5.0 milestone Apr 10, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
xtermjs/xterm.js@c5593bd...21b490f

Link provider fix
- Merge pull request xtermjs/xterm.js#2710 from jmbockhorst/linkFix

Leaked reference
- Merge pull request xtermjs/xterm.js#2767 from JavaCS3/fix/addDisposableDomListener-leak

Missing cursor fix
- Merge pull request xtermjs/xterm.js#2731 from jerch/fix_2729

Accessibility fix
- Merge pull request xtermjs/xterm.js#2814 from Tyriar/role_list

Fixes microsoft#93480

Showcase

Merge pull request xtermjs/xterm.js#2761 from slel/patch-1
Merge pull request xtermjs/xterm.js#2723 from UziTech/patch-1

Test, doc, build improvements

Merge pull request xtermjs/xterm.js#2766 from Tyriar/readme
Merge pull request xtermjs/xterm.js#2786 from Tyriar/eslint
Merge pull request xtermjs/xterm.js#2799 from Tyriar/enum_like_upper_case
Merge pull request xtermjs/xterm.js#2730 from Tyriar/ts38
Merge pull request xtermjs/xterm.js#2753 from jerch/fix_vtfeatures_template
Merge pull request xtermjs/xterm.js#2754 from jerch/fix_vtfeatures_2
Merge pull request xtermjs/xterm.js#2722 from Tyriar/linux_tests
Merge pull request xtermjs/xterm.js#2712 from jmbockhorst/playwright
Merge pull request xtermjs/xterm.js#2800 from Tyriar/upgrade_mac

Many dependency updates

Merge pull request xtermjs/xterm.js#2758 from Tyriar/acorn
Merge pull request xtermjs/xterm.js#2770 from xtermjs/dependabot/npm_and_yarn/deep-eq…
Merge pull request xtermjs/xterm.js#2779 from xtermjs/dependabot/npm_and_yarn/webpack…
Merge pull request xtermjs/xterm.js#2760 from xtermjs/dependabot/npm_and_yarn/acorn-5…
Merge pull request xtermjs/xterm.js#2772 from xtermjs/dependabot/npm_and_yarn/https-p…
Merge pull request xtermjs/xterm.js#2783 from Tyriar/deps
Merge pull request xtermjs/xterm.js#2795 from xtermjs/dependabot/npm_and_yarn/types/w…
Merge pull request xtermjs/xterm.js#2801 from xtermjs/dependabot/npm_and_yarn/types/w…
Merge pull request xtermjs/xterm.js#2780 from xtermjs/dependabot/npm_and_yarn/types/w…
Merge pull request xtermjs/xterm.js#2792 from xtermjs/dependabot/npm_and_yarn/mocha-7…
Merge pull request xtermjs/xterm.js#2803 from Tyriar/more_deps
Merge pull request xtermjs/xterm.js#2805 from xtermjs/dependabot/npm_and_yarn/mustach…
Merge pull request xtermjs/xterm.js#2810 from xtermjs/dependabot/npm_and_yarn/deep-eq…
Merge pull request xtermjs/xterm.js#2815 from xtermjs/dependabot/npm_and_yarn/nyc-15.0.1
Merge pull request xtermjs/xterm.js#2820 from xtermjs/dependabot/npm_and_yarn/typescr…
Merge pull request xtermjs/xterm.js#2819 from xtermjs/dependabot/npm_and_yarn/typescr…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/bug Something is misbehaving type/documentation Regarding website, API documentation, README, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants