Only removeChild valid children in DomRenderer dispose#2962
Merged
Tyriar merged 3 commits intoxtermjs:masterfrom Jun 4, 2020
JoshuaKGoldberg:dom-renderer-dispose-children
Merged
Only removeChild valid children in DomRenderer dispose#2962Tyriar merged 3 commits intoxtermjs:masterfrom JoshuaKGoldberg:dom-renderer-dispose-children
Tyriar merged 3 commits intoxtermjs:masterfrom
JoshuaKGoldberg:dom-renderer-dispose-children
Conversation
Tyriar
reviewed
Jun 4, 2020
Comment on lines
+107
to
+109
| if (element.parentElement === this._screenElement) { | ||
| this._screenElement.removeChild(element); | ||
| } |
Member
There was a problem hiding this comment.
Would this work instead to be more concise?
this.._rowContainer.parentNode?.removeChild(this._rowContainer);
We could also start a browser/Dom.ts for helpers like this: removeFromParent(...elements: HTMLElement[])
Contributor
Author
There was a problem hiding this comment.
I think that works, yes! Updated.
For browser/Dom.ts, I'll let you do that 😄 I don't have a good feeling for this repository's style preferences.
Tyriar
approved these changes
Jun 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2960
I did a scan for where I should add unit tests but it looks like the DOM renderer itself isn't unit tested - just
DomRendererRowFactory.