Skip to content

fix renderer pausing inadvertently in some cases#2999

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
andrew-schlackman:fix-renderer-pause
Jul 10, 2020
Merged

fix renderer pausing inadvertently in some cases#2999
Tyriar merged 1 commit intoxtermjs:masterfrom
andrew-schlackman:fix-renderer-pause

Conversation

@andrew-schlackman
Copy link
Copy Markdown

Fixes #2998

Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Just making sure, did you verify this fixes the issue?

@Tyriar Tyriar added this to the 4.8.0 milestone Jul 10, 2020
@Tyriar Tyriar merged commit 85a2589 into xtermjs:master Jul 10, 2020
@andrew-schlackman
Copy link
Copy Markdown
Author

Thanks for the accept!

I did verify that it fixes the issue in my case.

@Tyriar
Copy link
Copy Markdown
Member

Tyriar commented Jul 10, 2020

Great! I just released 4.8.0 so you can pick this up 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal.Open during expand animation can cause indefinitely paused renderer

3 participants