-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add support for OSC 4 ; color ; color spec #3163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5c7644a
Add rudimenatary and not fully working support of OSC 4
slawekzachcial 1c3da7e
Merge branch 'master' into add-osc-4
slawekzachcial b22d7f1
Move color parsing from Terminal to InputHandler
slawekzachcial b127436
Fix TODO comment
slawekzachcial 712f0ae
Merge branch 'master' into add-osc-4
slawekzachcial b898e01
Add IAnsiColorChangeEvent type
slawekzachcial d5f4ae5
Add IAnsiColorChangeEvent related tests
slawekzachcial bc86b78
Use all and not only 16 Ansi colors in CharAtlas config
slawekzachcial 77ed5ba
Add terminal sequence doc
slawekzachcial 6535995
Update OSC 4 description to match #3036
slawekzachcial e6917d1
Clarify color spec description
slawekzachcial 4c6dc45
Merge branch 'master' into add-osc-4
slawekzachcial 52b64be
Make InputHandler parseAnsiColorChange private
slawekzachcial f4a5638
Fix quotes
slawekzachcial 5a74ce2
Add Ansi color change positive test
slawekzachcial 2804bfa
Make safe references to colorManager in _changeAnsiColor
slawekzachcial 7d3f537
Implement OSC 4 for list of colors
slawekzachcial 5c33e40
Make _parseAnsiColorChange available for tests in TestInputHandler
slawekzachcial 676aabc
Merge branch 'master' into add-osc-4
slawekzachcial 19c14b0
Remove resolved TODO
Tyriar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional method on
Terminalis an unlucky choice, as we try to get rid of helpers on terminal in favor of more direct service usage. Can we get this moved to the color manager directly? Not sure if it is properly service'ified yet, if not we can keep it here and move it later on...I dont like the
!much, as it might lead to runtime errors in case the manager is indeed not there for whatever reason. Lets better hide the access behind an initial condition test, something likeif (!this._colorManager) { return; }...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
if (!this._colorManager) { return; }is a good idea here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerch The function now exists early if
_colorManageris undefined.