Skip to content

Make alt+click behavior configurable #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 5 commits into from
Nov 24, 2020
Merged

Make alt+click behavior configurable #3181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04e2bdd
Make alt+click behavior configurable
Nov 21, 2020
f68ff2a
Check for alt+click option sooner
Nov 22, 2020
78ddb9f
Add 'altClickMovesCursor' option to getOption/setOption in Terminal
Nov 22, 2020
88f0b91
add altClickMovesCursor option to Services type
Nov 22, 2020
e3cccd6
Update typings/xterm.d.ts
Tyriar Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser/services/SelectionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ export class SelectionService extends Disposable implements ISelectionService {
this._bufferService.rows,
false
);
if (coordinates && coordinates[0] !== undefined && coordinates[1] !== undefined) {
if (this._optionsService.getOption('altClickMovesCursor') && coordinates && coordinates[0] !== undefined && coordinates[1] !== undefined) {
Copy link
Copy Markdown
Contributor

@mofux mofux Nov 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the check for this option should be moved up to the parent if statement:

xterm.js/src/browser/services/SelectionService.ts

Line 670 in 04e2bdd

if (this.selectionText.length <= 1 && timeElapsed < ALT_CLICK_MOVE_CURSOR_TIME && event.altKey) {

const sequence = moveToCellSequence(coordinates[0] - 1, coordinates[1] - 1, this._bufferService, this._coreService.decPrivateModes.applicationCursorKeys);
this._coreService.triggerDataEvent(sequence, true);
}
Expand Down
2 changes: 1 addition & 1 deletion src/common/services/OptionsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const DEFAULT_OPTIONS: ITerminalOptions = Object.freeze({
windowOptions: {},
windowsMode: false,
wordSeparator: ' ()[]{}\',"`',

altClickMovesCursor: true,
convertEol: false,
termName: 'xterm',
cancelEvents: false
Expand Down
1 change: 1 addition & 0 deletions src/common/services/Services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ export interface IPartialTerminalOptions {
export interface ITerminalOptions {
allowProposedApi: boolean;
allowTransparency: boolean;
altClickMovesCursor: boolean;
bellSound: string;
bellStyle: 'none' | 'sound' /* | 'visual' | 'both' */;
cols: number;
Expand Down
5 changes: 5 additions & 0 deletions typings/xterm.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ declare module 'xterm' {
*/
allowTransparency?: boolean;

/**
* If enabled, alt + click will move the prompt cursor to position underneath the mouse.
*/
Comment thread
Tyriar marked this conversation as resolved.
altClickMovesCursor?: boolean;

/**
* A data uri of the sound to use for the bell when `bellStyle = 'sound'`.
*/
Expand Down