Skip to content

Fix bug of some IMEs cannot input in terminal #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 4 commits into from
Mar 18, 2021
Merged

Fix bug of some IMEs cannot input in terminal #3251

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7968b7c
Fix bug of some IMEs cannot input in terminal
Python-37 Mar 10, 2021
d392bdb
Merge branch 'master' into Fix-bug-of-some-IMEs-cannot-input-in-terminal
Tyriar Mar 18, 2021
00bdd28
Ensure in js that the textarea is always > 1x1px
Tyriar Mar 18, 2021
886f285
Remove old setting dimensions
Tyriar Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/browser/input/CompositionHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,9 @@ export class CompositionHelper {
const compositionViewBounds = this._compositionView.getBoundingClientRect();
this._textarea.style.left = cursorLeft + 'px';
this._textarea.style.top = cursorTop + 'px';
// Ensure the text area is at least 1x1, otherwise certain IMEs may break
this._textarea.style.width = Math.max(compositionViewBounds.width, 1) + 'px';
this._textarea.style.height = Math.max(compositionViewBounds.height, 1) + 'px';
this._textarea.style.width = compositionViewBounds.width + 'px';
this._textarea.style.height = compositionViewBounds.height + 'px';
Copy link
Copy Markdown
Contributor

@bmf-ribeiro bmf-ribeiro Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this._textarea.style.width = compositionViewBounds.width + 'px';
this._textarea.style.height = compositionViewBounds.height + 'px';

Shouldn't this 2 lines be removed?

Copy link
Copy Markdown
Member

@Tyriar Tyriar Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

this._textarea.style.lineHeight = compositionViewBounds.height + 'px';
Expand Down