add onContextLoss to webgl addon#3276
Merged
meganrogge merged 6 commits intoxtermjs:masterfrom Apr 2, 2021
Merged
Conversation
Tyriar
reviewed
Apr 1, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Should we call this _onContextLoss instead and pass the actual event over so it can be prevented if desired?
meganrogge
changed the title
Tyriar
approved these changes
Apr 1, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Good to go after adding the API to https://github.com/xtermjs/xterm.js/blob/master/addons/xterm-addon-webgl/typings/xterm-addon-webgl.d.ts
Member
|
Also I added a bit to the readme on handling context loss, improvements welcome 🙂 |
This was referenced Apr 2, 2021
This was referenced Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that VS code can fall back to dom when the webgl renderer loses context
Fixes #2253