input: handle input from macOS and Windows emoji panels#3429
Merged
Tyriar merged 3 commits intoxtermjs:masterfrom Aug 30, 2021
Merged
input: handle input from macOS and Windows emoji panels#3429Tyriar merged 3 commits intoxtermjs:masterfrom
Tyriar merged 3 commits intoxtermjs:masterfrom
Conversation
Member
|
FWIW Windows already seems to work fine for me as long as you're using wsl |
Tyriar
approved these changes
Aug 30, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
This works great! One of the top voted issues done 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
inputevent listener to the textarea to handle emoji IME events.Closes #469. Tested on Windows and macOS