Expose typed options from OptionsService through terminal.options#3448
Merged
Tyriar merged 8 commits intoxtermjs:masterfrom Oct 22, 2021
silamon:options1
Merged
Expose typed options from OptionsService through terminal.options#3448Tyriar merged 8 commits intoxtermjs:masterfrom silamon:options1
Tyriar merged 8 commits intoxtermjs:masterfrom
silamon:options1
Conversation
Member
|
Added |
Tyriar
requested changes
Oct 22, 2021
Tyriar
approved these changes
Oct 22, 2021
Member
Tyriar
left a comment
There was a problem hiding this comment.
Looks great, thanks I've wanted this for quite a while 🎉
Member
|
This PR creates a significant perf decrease in common modules, which have to ask option service for options (e.g. xterm.js/src/common/services/OptionsService.ts Lines 98 to 107 in 0bc02d6 Fix: dont use getter/setter in fast path code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use typed options in the terminal addons. Much or less the example from one of the related issues.
As far as I am aware, this doesn't introduce breaking changes (yet).
There are some following up possibilities:
Related: #2522, #3369