Skip to content

Report focus state on DECSET 1004#3506

Merged
Tyriar merged 2 commits intoxtermjs:masterfrom
Tyriar:2333_sendfocus
Oct 12, 2021
Merged

Report focus state on DECSET 1004#3506
Tyriar merged 2 commits intoxtermjs:masterfrom
Tyriar:2333_sendfocus

Conversation

@Tyriar
Copy link
Copy Markdown
Member

@Tyriar Tyriar commented Oct 12, 2021

Fixes #2333

@Tyriar Tyriar added this to the 4.15.0 milestone Oct 12, 2021
@Tyriar Tyriar requested a review from jerch October 12, 2021 16:06
@Tyriar Tyriar self-assigned this Oct 12, 2021
Copy link
Copy Markdown
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as in gnome-terminal. 👍

@Tyriar Tyriar enabled auto-merge October 12, 2021 16:38
@jerch
Copy link
Copy Markdown
Member

jerch commented Oct 12, 2021

@Tyriar Flakey test cases? I see this happening once in while, but only on macos and windows integration tests. Any clue how come, and why not on linux integration tests?

@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Oct 12, 2021

One of the mouse related ones was an actual timeout and I think I split it up, maybe this is another one that needs splitting?

@Tyriar Tyriar disabled auto-merge October 12, 2021 18:58
@Tyriar Tyriar merged commit 80d4742 into xtermjs:master Oct 12, 2021
@Tyriar Tyriar deleted the 2333_sendfocus branch October 12, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report focus state on activation of DECSET 1004

2 participants