Skip to content

input: prevent duplicate IME input on Linux - fixes #3533 #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 3 commits into from
Dec 17, 2021
Merged

input: prevent duplicate IME input on Linux - fixes #3533 #3535

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a4e88d
input: prevent duplicate IME input on Linux - fixes #3533
Eugeny Oct 31, 2021
cfa0b30
Merge branch 'master' into fix-duplicate-ime-input
Eugeny Oct 31, 2021
f030307
Merge branch 'master' into fix-duplicate-ime-input
Eugeny Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser/Terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
protected _inputEvent(ev: InputEvent): boolean {
// Only support emoji IMEs when screen reader mode is disabled as the event must bubble up to
// support reading out character input which can doubling up input characters
if (ev.data && ev.inputType === 'insertText' && !this.optionsService.options.screenReaderMode) {
if (ev.data && ev.inputType === 'insertText' && !ev.composed && !this.optionsService.options.screenReaderMode) {
if (this._keyPressHandled) {
return false;
}
Expand Down