Conversation
Tyriar
left a comment
There was a problem hiding this comment.
I know this is just a proof of concept, do you think it's worth the extra complexity to support this one? If we can support it so the perf overhead is negligible on print when no protected flags happen then I'm not opposed.
|
Tbh - I dont know, but lean somewhat more towards no support. Indeed the overhead is not as much as I thought in the beginning, also the code duplication of the PoC can be shortened alot by using some handler arguments. But I am not sure yet whether the PoC already covers all aspects of the protected flag thingy, thus should be tested first by someone with an actual use case. Without any real world test case there is a high chance we get it partially wrong, or introduce more ugly reworks down the road. Thus my hesitation. |
|
@jerch sounds good, it's just one bit and we've got extended attributes working pretty well now |
|
Superseeded by #4098. |
Currently just a quickly hacked PoC for protected flag support (so far only tested manually on canvas renderer).
@stuboydl: Maybe try this one out?