Remove selection-specific render pass, use bg overrides instead#3783
Merged
Tyriar merged 2 commits intoxtermjs:masterfrom May 11, 2022
Merged
Remove selection-specific render pass, use bg overrides instead#3783Tyriar merged 2 commits intoxtermjs:masterfrom
Tyriar merged 2 commits intoxtermjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #3775
Part of #3778
This PR removes the additional render pass specific to selections along with the attribute buffer and supporting methods, instead using the bg override system added in #3775. Essentially replacing all that code with just:
And the
_isCellSelecteddefinition.Consolidating selection rendering into the bg override system will allow controlling the rendering layers for #3778 such that decorations can be above or below the selection. It also applies minimum contrast ratio to the selection's background which I don't think was happening before.
Why didn't I do this to begin with? Resolving the inverse colors ahead of time wasn't worked through yet and there was the problem of how to handle the cache keys. Since we have that now this seems like the better approach from maintainability as well as for cpu/gpu/memory performance.