Skip to content

reset search result index when buffer changes/ terminal is resized #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrogge merged 3 commits into from
May 13, 2022
Merged

reset search result index when buffer changes/ terminal is resized #3793

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a332b5b
fix #3724
meganrogge May 12, 2022
b3b34b2
Update addons/xterm-addon-search/src/SearchAddon.ts
meganrogge May 12, 2022
ddfc05a
Merge branch 'master' into fix-search-index
meganrogge May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addons/xterm-addon-search/src/SearchAddon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export class SearchAddon implements ITerminalAddon {
if (this._cachedSearchTerm && this._lastSearchOptions?.decorations) {
this._highlightTimeout = setTimeout(() => {
this.findPrevious(this._cachedSearchTerm!, { ...this._lastSearchOptions, incremental: true, noScroll: true });
this._resultIndex = this._searchResults ? this._searchResults.size -1 : -1;
Comment thread
Tyriar marked this conversation as resolved.
this._onDidChangeResults.fire({ resultIndex: this._searchResults ? this._searchResults.size - 1 : -1, resultCount: this._searchResults ? this._searchResults.size : -1 });
}, 200);
}
Expand Down