Skip to content

Dom renderer: top decorations above selection #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 2 commits into from
May 13, 2022
Merged

Dom renderer: top decorations above selection #3800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a50cfa
Dom renderer: top decorations above selection
Tyriar May 13, 2022
a458bae
Update src/browser/renderer/dom/DomRendererRowFactory.ts
Tyriar May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions css/xterm.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,3 +183,8 @@
right: 0;
pointer-events: none;
}

.xterm-decoration-top {
z-index: 2;
position: relative;
}
5 changes: 5 additions & 0 deletions src/browser/renderer/dom/DomRendererRowFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,11 @@ export class DomRendererRowFactory {
isTop = d.options.layer === 'top';
}

// If it's a top decoration, render on above the selection
Comment thread
Tyriar marked this conversation as resolved.
Outdated
if (isTop) {
charElement.classList.add(`xterm-decoration-top`);
}

// Foreground
switch (fgColorMode) {
case Attributes.CM_P16:
Expand Down