Skip to content

Dispose blink state manager #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 2 commits into from
Aug 10, 2023
Merged

Dispose blink state manager #4659

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adad53d
Dispose blink state manager
SvanT Aug 10, 2023
3b30123
Use disposable registration
SvanT Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addons/xterm-addon-webgl/src/WebglRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ export class WebglRenderer extends Disposable implements IRenderer {
for (const l of this._renderLayers) {
l.dispose();
}
this._cursorBlinkStateManager?.dispose();
Comment thread
SvanT marked this conversation as resolved.
Outdated
this._canvas.parentElement?.removeChild(this._canvas);
removeTerminalFromCache(this._terminal);
}));
Expand Down