Skip to content

fix: memory leak in CoreBrowserService #4936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 5 commits into from
Apr 21, 2024
Merged

fix: memory leak in CoreBrowserService #4936

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0667aa
fix: memory leak in CoreBrowserService
SimonSiefke Jan 4, 2024
9e98b63
use disposable for text area listeners
SimonSiefke Jan 4, 2024
f486989
fix formatting
SimonSiefke Jan 4, 2024
819254e
fix formatting
SimonSiefke Jan 4, 2024
af8a663
Merge branch 'master' into fix/memory-leak
Tyriar Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/browser/services/CoreBrowserService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class CoreBrowserService extends Disposable implements ICoreBrowserServic

private _isFocused = false;
private _cachedIsFocused: boolean | undefined = undefined;
private _screenDprMonitor = new ScreenDprMonitor(this._window);
private _screenDprMonitor = this.register(new ScreenDprMonitor(this._window));

private readonly _onDprChange = this.register(new EventEmitter<number>());
public readonly onDprChange = this._onDprChange.event;
Expand All @@ -31,8 +31,12 @@ export class CoreBrowserService extends Disposable implements ICoreBrowserServic
this.register(this.onWindowChange(w => this._screenDprMonitor.setWindow(w)));
this.register(forwardEvent(this._screenDprMonitor.onDprChange, this._onDprChange));

this._textarea.addEventListener('focus', () => this._isFocused = true);
this._textarea.addEventListener('blur', () => this._isFocused = false);
this.register(
addDisposableDomListener(this._textarea, 'focus', () => (this._isFocused = true))
);
this.register(
addDisposableDomListener(this._textarea, 'blur', () => (this._isFocused = false))
);
}

public get window(): Window & typeof globalThis {
Expand Down