Skip to content

Only log character codes for trace log #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 3 commits into from
Oct 17, 2025
Merged

Only log character codes for trace log #5420

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5269462
Only log character codes for verbose/trace
anthonykim1 Oct 17, 2025
f87e574
Update src/common/services/CoreService.ts
anthonykim1 Oct 17, 2025
67cf259
only send codes, not the data when in trace
anthonykim1 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/common/services/CoreService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,17 @@ export class CoreService extends Disposable implements ICoreService {
}

// Fire onData API
this._logService.debug(`sending data "${data}"`, () => data.split('').map(e => e.charCodeAt(0)));
this._logService.debug(`sending data "${data}"`);
this._logService.trace(`sending data "${data}", and their character codes:`, () => data.split('').map(e => e.charCodeAt(0)));
Comment thread
Tyriar marked this conversation as resolved.
Outdated
this._onData.fire(data);
}

public triggerBinaryEvent(data: string): void {
if (this._optionsService.rawOptions.disableStdin) {
return;
}
this._logService.debug(`sending binary "${data}"`, () => data.split('').map(e => e.charCodeAt(0)));
this._logService.debug(`sending binary "${data}"`);
this._logService.trace(`sending binary "${data}", and their character codes:`, () => data.split('').map(e => e.charCodeAt(0)));
Comment thread
anthonykim1 marked this conversation as resolved.
Outdated
this._onBinary.fire(data);
}
}
Loading