Fix testsuite access to internal _extendedAttrs#5748
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Mar 10, 2026
Merged
Conversation
Tyriar
approved these changes
Mar 10, 2026
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
👍 less as any is always a good thing
PerBothner
added a commit
to PerBothner/xterm.js
that referenced
this pull request
Mar 23, 2026
…putHandler.test.ts. This is a followup to pull request xtermjs#5748. It removes the remaining test uses of internal _extendedAttrs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BufferLine.test.tsmakes many references to the internal property_extendedAttrs. This is undesirable; one reason it conflicts with some possible desirable reimplementations ofBufferLine. It is easy to fix, as suggested by this PR.