fix(addon-web-links): preserve wrapped URL detection after reflow#5768
Closed
SergioChan wants to merge 2 commits intoxtermjs:masterfrom
Closed
fix(addon-web-links): preserve wrapped URL detection after reflow#5768SergioChan wants to merge 2 commits intoxtermjs:masterfrom
SergioChan wants to merge 2 commits intoxtermjs:masterfrom
Conversation
Member
|
really? duplicate of #5767 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebLinkProviderby re-scanning wrapped continuation rows and rebuilding contiguous link text before range matching.Testing
npx eslint addons/addon-web-links/src/WebLinkProvider.ts addons/addon-web-links/test/WebLinksAddon.test.tsnpm run build(fails in this environment because@typescript/native-preview-win32-x64is missing from the local toolchain setup)Related
Fixes #5412