Skip to content

encoding article#95

Merged
jerch merged 10 commits intoxtermjs:masterfrom
jerch:encoding
Nov 7, 2019
Merged

encoding article#95
jerch merged 10 commits intoxtermjs:masterfrom
jerch:encoding

Conversation

@jerch
Copy link
Copy Markdown
Member

@jerch jerch commented Oct 2, 2019

WIP.

Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great starting point, we can merge this in after the minor feedback is addressed and always improve upon it later if we want to.

Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
Comment thread _docs/guides/encoding.md Outdated
@jerch
Copy link
Copy Markdown
Member Author

jerch commented Nov 7, 2019

@Tyriar
Done with it. Plz have a look at the luit/iconv parts, made them a bit more verbose with examples.

Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jerch jerch merged commit e7b5aee into xtermjs:master Nov 7, 2019
@jerch jerch deleted the encoding branch November 7, 2019 16:05
@Tyriar Tyriar removed the work-in-progress Do not merge label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants