Skip to content

Added unwrapTags option to paste extension#1177

Merged
nmielnik merged 2 commits into
yabwe:masterfrom
paradite:unwrapTags
Aug 20, 2016
Merged

Added unwrapTags option to paste extension#1177
nmielnik merged 2 commits into
yabwe:masterfrom
paradite:unwrapTags

Conversation

@paradite

@paradite paradite commented Aug 13, 2016

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
New tests added? yes
Fixed tickets #1141
License MIT

Description

Added unwrapTags option to paste extension, which instead of removing the tag element entirely, removes the tag element but preserves its children.

See issue #1141 for detailed description.

I added a new test case and I did some manual testing with demo/clean-paste.html.

Please, don't submit /dist files with your PR!

@coveralls

coveralls commented Aug 13, 2016

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 5846a97 on paradite:unwrapTags into * on yabwe:master*.

@j0k3r

j0k3r commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

Looks good to me.
@nmielnik ?

@nmielnik

nmielnik commented Aug 20, 2016

Copy link
Copy Markdown
Member

This looks awesome, nice work @paradite !

  • Add a useful feature
  • Updated documentation
  • Good Comments
  • Add tests to cover all uses of the feature

You covered all the bases for a great PR! Also, thanks for update the TOC links for OPTIONS.md

I'll make a quick integration branch to make sure all the tests pass in SauceLabs, if they do they I'll just merge this in.

https://travis-ci.org/yabwe/medium-editor/builds/153796581

@nmielnik
nmielnik merged commit f5d2163 into yabwe:master Aug 20, 2016
@paradite

Copy link
Copy Markdown
Contributor Author

@nmielnik sorry, I just spotted a minor issue, the example in https://github.com/yabwe/medium-editor#paste-options is not updated with this option. Maybe you can a quick fix for that?

@nmielnik

Copy link
Copy Markdown
Member

Ah, forgot about the README! Yeah, I'll add something, great catch.

@nmielnik

Copy link
Copy Markdown
Member

@paradite thanks for pointing that out, I found a few other places in the documentation that needed updating:

56acee3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants