Skip to content

Adopt ember-ignore-children-helper #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Conversation

bjornharrtell
Copy link
Contributor

Intends to resolve #337.

@bjornharrtell
Copy link
Contributor Author

@lukemelia friendly nudge to ask if this is acceptable.

@lukemelia
Copy link
Contributor

@bjornharrtell This looks fine except we should not have a license file in addon/helpers.

@bjornharrtell
Copy link
Contributor Author

@lukemelia are you sure? it's the license from the adopted code, it says it has to be redistributed with the code.

@bjornharrtell
Copy link
Contributor Author

Of course, perhaps it's better to inline that in the code itself?

@lukemelia
Copy link
Contributor

Of course, perhaps it's better to inline that in the code itself?

Yes, inline in the helper file would be appropriate.

@bjornharrtell
Copy link
Contributor Author

@lukemelia done

@lukemelia lukemelia merged commit d647ab9 into yapplabs:master Jul 14, 2021
@lukemelia
Copy link
Contributor

Thanks @bjornharrtell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of old addon https://github.com/ef4/ember-ignore-children-helper
2 participants