fix: make require("cliui") work as expected for CJS #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shadowspawn this uses the suggestion you gave in yargs adding:
Which seemed to make things work pretty well for both CJS and ESM:
Thoughts? Do you think this hack (
export {ui as 'module.exports'};
) is reasonable, or is it going to bite us one day.BEGIN_COMMIT_OVERRIDE
fix: make require("cliui") work as expected for CJS
END_COMMIT_OVERRIDE