refactor: move and document getNpmAuthenticationHeader #3888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Dec 21, 2021
paul-soporan
commented
Dec 26, 2021
| `packages/plugin-compat/extra/fsevents/fsevents-*.js`, | ||
| overrides: [ | ||
| { | ||
| files: [`!packages/*/sources/{index,Plugin}.ts`], |
Member
Author
There was a problem hiding this comment.
While the correct value would be ['!packages/*/sources/index.ts', '!packages/yarnpkg-core/sources/Plugin.ts'], ESLint seems to still match the files if I put both negated patterns, even though the docs state that:
Override blocks can also specify patterns to exclude from matches. If a file matches any of the excluded patterns, the configuration won't apply.
arcanis
reviewed
Jan 26, 2022
packages/gatsby/gatsby-plugin-yarn-introspection/gatsby-node.js
Outdated
Show resolved
Hide resolved
merceyz
pushed a commit
that referenced
this pull request
Sep 21, 2022
* refactor: move and document getNpmAuthenticationHeader * refactor: feedback * chore: versions * revert: revert leftovers
1 task
merceyz
pushed a commit
that referenced
this pull request
Sep 28, 2022
* refactor: move and document getNpmAuthenticationHeader * refactor: feedback * chore: versions * revert: revert leftovers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The
getNpmAuthenticationHeaderhook was defined inside aHooks.tsfile instead of the index. Because of this, the hook extraction script didn't see that it wasn't documented.How did you fix it?
Moved it to
index.tsand added more checks to make sure that this can never happen again.Checklist