Skip to content

fix(pnpm): pnpm linker no longer removes node_modules when nm linker is active #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 2 commits into from
Mar 15, 2022
Merged

fix(pnpm): pnpm linker no longer removes node_modules when nm linker is active #4206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6b6745
Fix: pnpm linker no longer removes node_modules when nm linker is active
larixer Mar 10, 2022
93d3c39
Updates artifact cleanup code
larixer Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .yarn/versions/dafa68fb.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
releases:
"@yarnpkg/cli": patch
"@yarnpkg/plugin-pnpm": patch

declined:
- "@yarnpkg/plugin-compat"
- "@yarnpkg/plugin-constraints"
- "@yarnpkg/plugin-dlx"
- "@yarnpkg/plugin-essentials"
- "@yarnpkg/plugin-init"
- "@yarnpkg/plugin-interactive-tools"
- "@yarnpkg/plugin-nm"
- "@yarnpkg/plugin-npm-cli"
- "@yarnpkg/plugin-pack"
- "@yarnpkg/plugin-patch"
- "@yarnpkg/plugin-pnp"
- "@yarnpkg/plugin-stage"
- "@yarnpkg/plugin-typescript"
- "@yarnpkg/plugin-version"
- "@yarnpkg/plugin-workspace-tools"
- "@yarnpkg/builder"
- "@yarnpkg/core"
- "@yarnpkg/doctor"
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ Yarn now accepts sponsorships! Please give a look at our [OpenCollective](https:

## Master

### Installs
- The pnpm linker no longer tries to remove `node_modules` directory, when `node-modules` linker is active

**Note:** features in `master` can be tried out by running `yarn set version from sources` in your project (existing contrib plugins are updated automatically, while new contrib plugins can be added by running `yarn plugin import from sources <name>`).

## 3.2.0
Expand Down
5 changes: 3 additions & 2 deletions packages/plugin-pnpm/sources/PnpmLinker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,11 @@ class PnpmInstaller implements Installer {
}

// Wait for the package installs to catch up
await this.asyncActions.wait(),
await this.asyncActions.wait();
Copy link
Member

@arcanis arcanis Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this the reason for the flaky test? 🤯


await removeIfEmpty(storeLocation);
await removeIfEmpty(getNodeModulesLocation(this.opts.project));
if (this.opts.project.configuration.get(`nodeLinker`) !== `node-modules`)
await removeIfEmpty(getNodeModulesLocation(this.opts.project));

return {
customData: this.customData,
Expand Down