fix(docs): move Ukrainain banner to the home page only to not disrupt docs UX #4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We can start with that to fix the immediate UX issue 👍 |
arcanis
pushed a commit
that referenced
this pull request
Mar 24, 2022
merceyz
pushed a commit
that referenced
this pull request
Sep 21, 2022
merceyz
pushed a commit
that referenced
this pull request
Oct 5, 2022
merceyz
pushed a commit
that referenced
this pull request
Nov 16, 2022
merceyz
pushed a commit
that referenced
this pull request
Dec 20, 2022
merceyz
pushed a commit
that referenced
this pull request
Feb 1, 2023
merceyz
pushed a commit
that referenced
this pull request
Mar 16, 2023
merceyz
pushed a commit
that referenced
this pull request
May 1, 2023
merceyz
pushed a commit
that referenced
this pull request
Jun 1, 2023
merceyz
pushed a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
I have added Ukrainian banner initially to all the pages of the website and into a fixed position. Unfortunately this disrupts docs UX, because the banner takes much of vertical space.
How did you fix it?
I have left the banner on the home page only and made it a part of the content. I'm open to other ideas how to make the banner visible and not disrupt the docs UX on the same time.
Checklist