-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(extensions): allow consolidate@<0.16.0 to use mustache@^3.0.0
#4465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the range declared upstream, in order to change it here it needs to be changed upstream as well.
https://github.com/tj/consolidate.js/blob/ec2e1ae511d37a69716022311a4ca29785f62143/package.json#L121
consolidate to use mustache@^3.0.0
|
@merceyz the problem is that mustache@3 must be used with [email protected] and mustache@4 must be used with consolidate@^0.16.0 according to this. What is the best way to achieve that? Have a separate entry for consolidate<=0.15.1 and another one for consolidate>0.15.1? |
|
Closing in favor of #4467 |
|
There is no need to close this PR and open a new one, update this PR instead. |
Alright, in that case the need for an upstream PR is void 👍
Yes, add an entry before the current one that only targets |
testem specifies mustache@^3.0.0 and [email protected] in its dependencies. When you install testem using [email protected] it ends up with versions conflict: ``` . └─┬ ember-cli └─┬ testem └─┬ consolidate └── ✕ unmet peer mustache@^4.0.1: found 3.2.1 ```
|
@merceyz please check if I did it correctly. |
merceyz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
consolidate to use mustache@^3.0.0consolidate@<0.16.0 to use mustache@^3.0.0
testem specifies mustache@^3.0.0 and [email protected] in its dependencies.
When you install testem using [email protected] it ends up with versions conflict:
What's the problem this PR addresses?
...
How did you fix it?
...
Checklist