Exposes findPnpApi to non-PnP dependency trees
#696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Scripts that were running within the PnP runtime but outside the dependency tree had no way to access the PnP API from other dependency trees, since
require('pnpapi')would fail for them.How did you fix it?
I didn't want to expose
pnpapito modules outside of PnP dependency trees (mainly because I want to keep the expectation that the return ofrequire('pnpapi')will always be the instance for the current dependency tree, which isn't possible for those special modules), so I instead exposed it within themodulebuiltin.