Add development server e2e for gatsby #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh shoot, the test is wrong. Will update soon. |
|
@arcanis I believe this PR is ready for review! We're still waiting for the gatsby team to review the PR for fixing |
arcanis
reviewed
Jan 29, 2020
| @@ -87,7 +87,7 @@ jobs: | |||
| echo "import answer from 'the-answer'; import _ from 'lodash';" | tee src/main.js | |||
|
|
|||
| yarn rollup -c | |||
| cat dist/bundle.js | grep -v "lodash" | |||
| ! cat dist/bundle.js | grep "lodash" | |||
There was a problem hiding this comment.
TIL ! applies to the whole pipe in Bash, not only the command that follows 🤔
There was a problem hiding this comment.
Yah I couldn't find any doc on this either. I just tried it. Hope that I haven't encounter any edge case 😅
|
Good to go, thanks a lot! I think it's fair to post a small ping, but until they get a chance to merge your PR we can go ahead and merge a builtin package extensions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Related to #368 and #689. Test against development build (yarn start) for
gatsbyapp. Which includes some development only loaders likeeslint-loader.How did you fix it?
Since gatsbyjs/gatsby#20629 has landed and released, it should fix the test now.
There are still some plugins that are not supported yet, one would be gatsbyjs/gatsby#20638. We'll make another PR to make the test more comprehensive after upstream fixes the issue.
I also fix a bug in rollup e2e test where I accidentally use the wrong command 😞.