-
Notifications
You must be signed in to change notification settings - Fork 1k
Clarify that private scoped packages are not supported #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aren't public scoped packages supported? There's some issues in Git Bash on Windows (see yarnpkg/yarn#2785) but I thought it worked fine in most other environments. Perhaps this should clarify that private scoped packages are not supported? |
Good point! Updated the PR. |
What does private scoped packages mean? Do you mean fetching scoped packages from a registry that requires user authentication? I ask because private can, in my mind, imply a private company registry, where authenticate is not required. In that scenario scoped packages are supported by yarn. |
Private scoped packages, in this context, would mean scoped packages that require authentication to download. The phrase can be interpreted differently, however, there is some prior use of the phrase which is fairly common and well understood. The word "private" certainly doesn't lend itself to any particular implementation of privacy, but using the same phrase to describe different things is bound to be confusing. |
|
@seamusabshere's version sounds good to me! |
This is confusing. I'm currently using yarn with a lot of scoped, private packages on NPM's registry and it works fine. Is that just coincidence that it happens to work? Or are you going to be removing that capability? |
@shakefu maybe you could send a PR that documents this capability? I haven't gotten it to work, haven't found any documentation for it, and haven't heard of anybody else who has. Officially supporting it would probably be better than documenting that it isn't supported. |
@devtristan I'm not familiar with the actual doc repo to be able to easily make a PR otherwise I'd be happy to. Maybe you could point me in the right direction? But here's a quick snippet I copy+pasted showing # File and hostname specifics replaced with <SNIP> to protect the innocent (me)
$ yarn cache clean
yarn cache v0.21.3
success Cleared cache.
✨ Done in 7.17s.
$ rm -R ~/.npmrc ~/.yarnrc node_modules
$ yarn install
yarn install v0.21.3
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/@<SNIP>/<SNIP>-4.31.1.tgz: Request failed \"404 Not Found\"".
info If you think this is a bug, please open a bug report with the information provided in "<SNIP>/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
$ yarn login
yarn login v0.21.3
question npm username: shakefu
question npm email: shakefu@<SNIP>
✨ Done in 10.65s.
$ yarn install
yarn install v0.21.3
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/@<SNIP>/<SNIP>-4.31.1.tgz: Request failed \"404 Not Found\"".
info If you think this is a bug, please open a bug report with the information provided in "<SNIP>/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
$ rm -R ~/.npmrc ~/.yarnrc node_modules
$ npm login
Username: shakefu
Password:
Email: (this IS public) shakefu@<SNIP>
Logged in as shakefu on https://registry.npmjs.org/.
$ yarn install
yarn install v0.21.3
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
[4/4] 📃 Building fresh packages...
✨ Done in 9.66s.
$ |
That was a bug, I think we fixed it. |
It returns 403 error still and am using latest yarn. |
For what package @motss ? |
Still it is better to fix the bug than declare a defeat :) |
Scoped packages are a pretty common use case, and searching the internet for "yarn scoped packages" brings people to issues like yarnpkg/yarn#521 which generally end with a comment saying that scoped packages are now supported. Since they are not supported, I think adding this line to the website could save people some time.