Ensure publish hooks are run at the same time. (#4553)

Move publish, prepublish and prepare hooks to run before tar ball is
created.

Also switch the order of prepare to be consistent with
https://docs.npmjs.com/misc/scripts

Author: johnf

src/cli/commands/publish.js

@@ -32,6 +32,11 @@ async function publish(config: Config, pkg: any, flags: Object, dir: string): Pr
     throw new MessageError(config.reporter.lang('invalidAccess'));
   }
 
+  // TODO this might modify package.json, do we need to reload it?
+  await config.executeLifecycleScript('prepublish');
+  await config.executeLifecycleScript('prepare');
+  await config.executeLifecycleScript('prepublishOnly');
+
   // get tarball stream
   const stat = await fs.lstat(dir);
   let stream;
@@ -60,11 +65,6 @@ async function publish(config: Config, pkg: any, flags: Object, dir: string): Pr
   const tbName = `${pkg.name}-${pkg.version}.tgz`;
   const tbURI = `${pkg.name}/-/${tbName}`;
 
-  // TODO this might modify package.json, do we need to reload it?
-  await config.executeLifecycleScript('prepublish');
-  await config.executeLifecycleScript('prepublishOnly');
-  await config.executeLifecycleScript('prepare');
-
   // create body
   const root = {
     _id: pkg.name,