Ensure publish hooks are run at the same time. #4553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move publish, prepublish and prepare hooks to run before tar ball is created. Also switch the order of prepare to be consistent with https://docs.npmjs.com/misc/scripts
Member
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
Move publish, prepublish and prepare hooks to run before tar ball is created. Also switch the order of prepare to be consistent with https://docs.npmjs.com/misc/scripts
yhatt
added a commit
to yhatt/markdown-it-incremental-dom
that referenced
this pull request
Dec 30, 2017
`yarn publish` is already supported prepack script in yarn 1.0.0. (and prepublish scripts is running before packing in yarn 1.2.0) See: yarnpkg/yarn#4193 yarnpkg/yarn#4553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move publish, prepublish and prepare hooks to run before tar ball is
created.
Also switch the order of prepare to be consistent with
https://docs.npmjs.com/misc/scripts
Summary
Currently publish hooks are being run after tarball creation, this means that any output of this process e.g. processing by babel isn't included in the published artifacts.
Fixes #4515
Test plan
Create following package.json
{ "name": "hubber-iot", "scripts": { "build": "echo foo > bar.txt", "prepublish": "yarn run build", }, "version": "1.0.0" }Then
yarn publishbar.txt should be included in the module