Don't always prune mirrored scoped packages resolved by URLs #3342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With a
.yarnrc
configured for offline mirroring withyarn-offline-mirror-pruning
, packages that areresolved
inyarn.lock
to registry URLs, such as:...will indeed be mirrored as
@jupyterlab-about-extension-0.3.1.tgz
. However, this will be immediately pruned, as the tarball expected on disk will beabout-extension-0.3.1.tgz
(derived from the URL) which won't match as it is is not suitably mangled.This PR adds an extra expectedTarball for the pre-mangled version. I don't know if this is exactly the right approach, but local testing suggests it works, and since the expected-but-unfound tarballs aren't returned/checked, it didn't seem like it could hurt.
Test plan
This adds a new test case, with a copy of the existing mirror fixture, but with
yarn-offline-mirror-pruning
and ayarn.lock
as I have been seeing in my testing, as opposed to the file-based one. It didn't seem appropriate to add this to the original test case, but I can be easily persuaded otherwise!