[WIP] - Handle optional dependencies alongside resolutions #7272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
olingern
changed the title
olingern
commented
May 14, 2019
| @@ -283,13 +284,6 @@ export class Install { | |||
| Object.assign(this.resolutions, projectManifestJson.resolutions); | |||
| Object.assign(manifest, projectManifestJson); | |||
|
|
|||
| this.resolutionMap.init(this.resolutions); | |||
There was a problem hiding this comment.
This is moved to after pushDeps is so that we know what dependencies to not add
olingern
commented
May 14, 2019
olingern
commented
May 14, 2019
| @@ -306,6 +301,9 @@ export class Install { | |||
| return; | |||
| } | |||
| const depMap = manifest[depType]; | |||
| const workspaceName = manifest.name; | |||
There was a problem hiding this comment.
Done to pass linter line length below
|
Closing in favor of #7273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6040
Read my comment here for a summary of why and how I arrived at this.
Implementation details:
As mentioned in #6040, there are two entries for a given package being returned. So, this PR simply tracks dependencies by their
pattern. This does mean that it's version specific, so this is an assumption on my part, i.e. if[email protected]is optional and[email protected]is a resolution --[email protected]will still installThe fix:
I would consider this a WIP / draft since I will need to tackle tests and verify workspaces + resolutions are still intact.
Todos:
depMapvar should be used somehowTest plan
Tests to add: