fix(Tablet): remove nodeId from header and api requests for tablet #1461
Conversation
Raubzeug
changed the title
Raubzeug
changed the title
src/containers/Tablet/Tablet.tsx
Outdated
| clusterName: queryClusterName, | ||
| }, | ||
| ] = useQueryParams(tabletQueryParams); | ||
| const [{tenantName: queryDatabase, type: queryTabletType, clusterName: queryClusterName}] = |
There was a problem hiding this comment.
IMHO, tablet type should't be passed in query as well.
In the scenario, where we navigate to specific tablet by changing tablet id, we will need to change tablet type together with tablet id, otherwise it will be incorrect.
I think it won't hurt much, if correct tablet type appear in breadcrumbs after data is loaded. Until it happens, there will be a placeholder icon with T type [T].
There was a problem hiding this comment.
I've thought about this, but finally decided to leave tablet type in query string, cause as for me it doesn't hurt much: even if it will be incorrect, it will be replaced when tablet info is loaded. What do you think?
There was a problem hiding this comment.
I just don't like passing much in query strings, we already have very long links and they become even longer with every update. So for me, if there is no much difference, it's better not to pass
There was a problem hiding this comment.
Yeah, thats hurting truth! I agree with you! Lets get rid of query params if possible!
Raubzeug
force-pushed
the
1458-tabletinfo
branch
from
f958b60 to
f6e610c
Compare
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: 🔽
Current: 78.97 MB | Main: 78.97 MB
Diff: 0.01 MB (-0.01%)
✅ Bundle size decreased.
ℹ️ CI Information