feat(Storage): group disks by DC #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1430-group-disks-by-dc
branch
from
4708955 to
60fb338
Compare
artemmufazalov
commented
Jan 16, 2025
| <PDiskItem | ||
| key={vDisk?.PDisk?.StringifiedId} | ||
| vDisk={vDisk} | ||
| highlightedVDisk={highlightedVDisk} | ||
| setHighlightedVDisk={setHighlightedVDisk} | ||
| withDCMargin={vDisksWithDCMargins.includes(index)} |
There was a problem hiding this comment.
There is grouping only for PDisks here. This is done to keep VDisks relative sizes
artemmufazalov
requested review from
Raubzeug and
astandrik
and removed request for
Raubzeug
artemmufazalov
force-pushed
the
1430-group-disks-by-dc
branch
from
60fb338 to
8a591e4
Compare
Raubzeug
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1430
Test stand (with test data in Storage): https://nda.ya.ru/t/lltCf2Em7B9wQn
PDisks with VDisks:
Only VDisks:
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 79.96 MB | Main: 79.96 MB
Diff: +5.48 KB (0.01%)
ℹ️ CI Information