feat: make keyboard shortcuts help page #2116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 9 out of 14 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- package.json: Language not supported
- src/containers/AsideNavigation/AsideNavigation.scss: Language not supported
- src/containers/AsideNavigation/InformationPopup/InformationPopup.scss: Language not supported
- src/containers/AsideNavigation/i18n/en.json: Language not supported
- src/containers/Tenant/Query/i18n/en.json: Language not supported
Raubzeug
requested changes
Apr 9, 2025
| @@ -19,4 +19,9 @@ | |||
| width: 300px; | |||
| padding: 10px; | |||
| } | |||
|
|
|||
| &__hotkeys-panel-title { | |||
There was a problem hiding this comment.
Let's add animation when open Shortcuts pane (like for Settings pane).
| const [compact, setIsCompact] = useSetting<boolean>(ASIDE_HEADER_COMPACT_KEY); | ||
|
|
||
| const toggleInformationPopup = React.useCallback( | ||
| () => setInformationPopupVisible(!informationPopupVisible), |
There was a problem hiding this comment.
setInformationPopupVisible(prev => !prev)?
| @@ -103,6 +102,17 @@ export function YqlEditor({ | |||
| } | |||
| }); | |||
|
|
|||
| editor.addAction({ | |||
There was a problem hiding this comment.
Did you want to add it to editor's menu? If yes, you should add contextMenuGroupId, contextMenuOrder.
|
|
||
| return 'https://ydb.tech/docs/en/'; | ||
| Information = 'Information', | ||
| Hotkeys = 'Hotkeys', | ||
| } | ||
|
|
||
| export function AsideNavigation(props: AsideNavigationProps) { |
There was a problem hiding this comment.
Please, don't forget to make similar changes in internal version, there is a different navigation component there
Raubzeug
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1344
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ✨4 🗑️1
✨ New Tests (4)
🗑️ Deleted Tests (1)
Bundle Size: 🔺
Current: 83.36 MB | Main: 83.29 MB
Diff: +0.07 MB (0.08%)
ℹ️ CI Information