Skip to content

fix(PaginatedStorage): controls should be fixed #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025
Merged

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Apr 26, 2025

closes #2195
Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 315 0 3 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.37 MB | Main: 83.37 MB
Diff: +1.35 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

padding-right: 40px;
padding-left: 20px;

transform: translateX(-20px);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain how it works and where 40 and 20 px come from?
mb move them to css variables for clearance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short, it's black magic :)
If serious, we have our scroll container ydb-cluster with side paddings. And thats the trouble. So, I just mislead this paddings (we have similar styles for tabs). Maybe we should rework layout for all cluster page, what do u think?

Copy link
Collaborator

@astandrik astandrik Apr 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if current solution fixes current problem - we could merge it but as well we could create task to techdebt with description of what should be reworked

I dont think for now we have that much of a resource for massive reworks of that type

However sometimes it could be done

I checked this issue with many pdisks and vdidks with mocks from this pr #1793 and it seems to work

@Raubzeug Raubzeug added this pull request to the merge queue Apr 26, 2025
Merged via the queue into main with commit c12fed4 Apr 26, 2025
8 checks passed
@Raubzeug Raubzeug deleted the cluster-layout-bug branch April 26, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster page layout bug
2 participants